My mission is to see if PH RTB PP can work okay without code changes.
In my opinion, yes it can. Turns are fairly big circles. Vertical / thrust stuff probably needs to be tweaked to avoid throttle oscillation. Use INS13 with GPS-airspeed or hardware-airspeed enabled (UseAirspeedSensor), set up and calibrated by comparing to GPS speed during normal flight on calm, no wind day. Airspeed PID Scaling should be understood, enabled, and changed if needed, early on so that your PIDs are tuned with it enabled. Remember SystemSettings (max and min airspeeds) need to be set too. I should have spent more time on SafetyMargins. I setup up Manual mode and make manual linkage adjustments to get it flying well with trims centered. Add Rate (rate, rate, manual, manual) (tune PID). Add Attitude (attitude, attitude, manual, manual) (tune PID). Add PathPlanner and 2 point waypoint plan with error destination set to -1 on both waypoints and use it to get altitude / thrust oscillation fixed.
Be aware that when using a 2.4GHz RC to 433 OpLink relay box with OpLink control of aircraft, that you should never just turn the RC transmitter off because that causes the OpLink in the relay box to send full stick signals on all channels.
Configure and test both RTB and waypoint flight in "out of range mode" close to you to make sure that they do what you want them to. RTB should come home while climbing whatever you have configured. If I were to do long range waypoint flight, I would probably want it to continue doing the waypoints whether it was in RC range or out of RC range.
I usually make a small code change so that I can set RTB up as if it were an additional flight mode switch position that is only reachable in FC failsafe mode. You can do the same with RC failsafe mode moving the channel farther than you can move it with the switch.
I remember the first time I tried to set up GPS flight modes on a quad. I wondered why we have two separate vertical velocity PIDs; one in AltitudeHoldSettings and the other in VtolPfSettings. Maybe it was to make it clear that FwPfSettings doesn't have a vertical velocity PID.
FwPfSettings as a whole has settings that can be tuned like a vertical velocity PID, but it doesn't actually have one. It DOES has a vertical
position P as opposed to
velocity PID.
As suspected, a quick look at the code says that all aspects of fixed wing ignore AltitudeHoldSettings.
Oops, gotta go.